Skip to content

Set up a home directory for sidecar #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 11, 2019
Merged

Set up a home directory for sidecar #3450

openshift-merge-robot merged 1 commit into from
Apr 11, 2019

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Apr 11, 2019

Getting errors about OPENSSL

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2019
@smarterclayton smarterclayton removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@smarterclayton smarterclayton added lgtm Indicates that a PR is ready to be merged. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2019
@smarterclayton smarterclayton added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit c980073 into openshift:master Apr 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2019

@smarterclayton: Updated the following 2 configmaps:

  • prow-job-master-sidecar-4 configmap in namespace ci using the following files:
    • key master-sidecar-4.yaml using file ci-operator/templates/master-sidecar-4.yaml
  • prow-job-master-sidecar-4 configmap in namespace ci-stg using the following files:
    • key master-sidecar-4.yaml using file ci-operator/templates/master-sidecar-4.yaml
Details

In response to this:

Getting errors about OPENSSL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton smarterclayton mentioned this pull request Apr 12, 2019
Merged
@smarterclayton smarterclayton deleted the sidecar branch April 24, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@droslean droslean Awaiting requested review from droslean

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smarterclayton @openshift-ci-robot @openshift-merge-robot