Skip to content

add extended-platform-tests repo #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 22, 2020
Merged

add extended-platform-tests repo #6794

openshift-merge-robot merged 1 commit into from
Jan 22, 2020

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Jan 21, 2020 •
edited
Loading

@deads2k

the image looks good here, I've tested locally that the following runs from a container, so I think we're good here:
extended-platform-tests run-test "[sig-storage] ConfigMap optional updates should be reflected in volume [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]" runs fine

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2020
@sallyom sallyom force-pushed the add-extended-platform-tests-repo branch from 0019560 to 15c15a1 Compare January 21, 2020 18:51
@sallyom sallyom mentioned this pull request Jan 21, 2020
Merged
@sallyom sallyom force-pushed the add-extended-platform-tests-repo branch from 15c15a1 to 626f630 Compare January 21, 2020 20:15
@sallyom
Copy link
Contributor Author

sallyom commented Jan 21, 2020

/retest

sallyom
sallyom commented Jan 21, 2020
View reviewed changes
...rator/config/openshift/extended-platform-tests/openshift-extended-platform-tests-master.yaml
to: extended-platform-tests
promotion:
name: "4.4"
namespace: ocp
Copy link
Contributor Author

@sallyom sallyom Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevekuznetsov this config will produce an image extended-platform-tests . We will add this image as in initcontainer to the cluster-launch-installer-e2e.yaml template, so that we can enable a new suite e2e-extended-platform in
all openshift repos, eventually. What do I need to do to make this image available to all? Will this config do it? I'm reading docs, but will ask you, too.

Copy link
Contributor Author

@sallyom sallyom Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image has the binary extended-platform-tests similar to very similar to openshift-tests

Copy link
Member

@petr-muller petr-muller Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sallyom yeah promoting the image will make it available for anyone whose tag_specification is ocp namespace, which is pretty much anyone who is interested in using these tests, I guess

@deads2k
Copy link
Contributor

deads2k commented Jan 22, 2020

I think this gets the extended-platform-test repo managed by prow.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@sallyom sallyom mentioned this pull request Jan 22, 2020
Closed
@mfojtik
Copy link
Contributor

mfojtik commented Jan 22, 2020

/lgtm

petr-muller
petr-muller reviewed Jan 22, 2020
View reviewed changes
core-services/prow/02_config/_plugins.yaml
require_self_approval: false
- repos:
- openshift/extended-platform-tests
require_self_approval: false
Copy link
Member

@petr-muller petr-muller Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why twice?

core-services/prow/02_config/_config.yaml
- openshift-kni/performance-addon-operators
- openshift-kni/cnf-features-deploy
- openshift-priv/ci-experiment-origin
- openshift/extended-platform-tests
Copy link
Member

@petr-muller petr-muller Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add this repo to the other long list, the one that configures tide for the non-master branches.

core-services/prow/02_config/_plugins.yaml
review_acts_as_lgtm: true
- repos:
- openshift/extended-platform-tests
review_acts_as_lgtm: true
Copy link
Member

@petr-muller petr-muller Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why twice?

petr-muller
petr-muller approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things I pointed out will not break anything and this is apparently urgent, so @mfojtik promised me someone will followup on them, so merging.

@petr-muller
Copy link
Member

petr-muller commented Jan 22, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik, petr-muller, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 626f630 into openshift:master Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

@sallyom: Updated the following 7 configmaps:

  • config configmap in namespace release-controller-test at cluster default using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-extended-platform-tests-master-postsubmits.yaml using file ci-operator/jobs/openshift/extended-platform-tests/openshift-extended-platform-tests-master-postsubmits.yaml
    • key openshift-extended-platform-tests-master-presubmits.yaml using file ci-operator/jobs/openshift/extended-platform-tests/openshift-extended-platform-tests-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-extended-platform-tests-master.yaml using file ci-operator/config/openshift/extended-platform-tests/openshift-extended-platform-tests-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-extended-platform-tests-master.yaml using file ci-operator/config/openshift/extended-platform-tests/openshift-extended-platform-tests-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-extended-platform-tests-master.yaml using file ci-operator/config/openshift/extended-platform-tests/openshift-extended-platform-tests-master.yaml
  • plugins configmap in namespace ci at cluster default using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • config configmap in namespace ci at cluster default using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
Details

In response to this:

@deads2k

the image looks good here, I've tested locally that the following runs from a container, so I think we're good here:
extended-platform-tests run-test "[sig-storage] ConfigMap optional updates should be reflected in volume [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]" runs fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droslean droslean Awaiting requested review from droslean

@jupierce jupierce Awaiting requested review from jupierce

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mfojtik mfojtik

@petr-muller petr-muller

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sallyom @deads2k @mfojtik @petr-muller @openshift-ci-robot @openshift-merge-robot