Fix ORIGINAL_RELEASE_IMAGE_LATEST unbound variable in rosa-sts-account-roles-create #72041
Conversation
…t-roles-create The rosa-sts-account-roles-create step was failing with 'unbound variable' error when ORIGINAL_RELEASE_IMAGE_LATEST is not set. This happens because the script has 'set -o nounset' which causes it to fail on undefined variables. This appears to be caused by a ci-operator regression that started around Nov 22, 2025. The variable should be automatically set by ci-operator when a config has releases.latest defined, but it's not being set for variant configurations. This fix adds a check to ensure ORIGINAL_RELEASE_IMAGE_LATEST is set before attempting to use it. If the variable is not set, the script falls back to the existing logic that queries the version list from ROSA CLI. Fixes: periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn
|
@wangke19: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-ci. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn |
|
@wangke19: the repo openshift/release does not contribute to the OpenShift official images, or the base branch is not currently having images promoted |
|
[REHEARSALNOTIFIER]
A total of 234 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn |
|
@wangke19: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/assign @yasun1 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn openshift/origin#30536 |
|
@wangke19: the repo openshift/release does not contribute to the OpenShift official images, or the base branch is not currently having images promoted |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wangke19, yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
|
@wangke19: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/pr-rehearse ack |
|
@wangke19: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit c3fcec5
into
openshift:master
wangke19
deleted the
fix-rosa-sts-account-roles-original-release-image
branch
…t-roles-create (openshift#72041) The rosa-sts-account-roles-create step was failing with 'unbound variable' error when ORIGINAL_RELEASE_IMAGE_LATEST is not set. This happens because the script has 'set -o nounset' which causes it to fail on undefined variables. This appears to be caused by a ci-operator regression that started around Nov 22, 2025. The variable should be automatically set by ci-operator when a config has releases.latest defined, but it's not being set for variant configurations. This fix adds a check to ensure ORIGINAL_RELEASE_IMAGE_LATEST is set before attempting to use it. If the variable is not set, the script falls back to the existing logic that queries the version list from ROSA CLI. Fixes: periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn
…t-roles-create (openshift#72041) The rosa-sts-account-roles-create step was failing with 'unbound variable' error when ORIGINAL_RELEASE_IMAGE_LATEST is not set. This happens because the script has 'set -o nounset' which causes it to fail on undefined variables. This appears to be caused by a ci-operator regression that started around Nov 22, 2025. The variable should be automatically set by ci-operator when a config has releases.latest defined, but it's not being set for variant configurations. This fix adds a check to ensure ORIGINAL_RELEASE_IMAGE_LATEST is set before attempting to use it. If the variable is not set, the script falls back to the existing logic that queries the version list from ROSA CLI. Fixes: periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn
3 participants
Summary
Fixes the
periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovnjob that has been failing since Nov 22, 2025 with:Root Cause
The
rosa-sts-account-roles-createstep script usesset -o nounsetand attempts to accessORIGINAL_RELEASE_IMAGE_LATESTwithout checking if it's set. This variable should be automatically provided by ci-operator whenreleases.latestis configured, but it appears to not be set for variant configurations due to a ci-operator regression.Changes
Added a defensive check before using
ORIGINAL_RELEASE_IMAGE_LATEST:Testing
The fix makes the script more robust by:
/cc @openshift/openshift-team-ci