Enable selective PVC restore by moving size patch to backup action and updating CSI additional items

[amastbau]

https://issues.redhat.com/browse/OADP-5608
https://issues.redhat.com/browse/OADP-5939
OADP-5608
OADP-5939

Summary of Changes:

1. Move PVC Request Size Patch to Backup CSI Action
   Shifted the logic that patches the PVC request size (to match the corresponding VolumeSnapshot size) from the CSI Restore action to the CSI Backup action.
   ✅ This enables restoring a PVC independently using label selectors, without requiring the VolumeSnapshot to be restored first.

2. Include VolumeSnapshot in CSI Additional Items for PVC
   Added VolumeSnapshot as an additional item in the PVC CSI backup logic to ensure necessary metadata is available during restore.

3. Include VolumeSnapshotContent in CSI Restore Additional Items
   Added VolumeSnapshotContent to the additional items in the CSI restore action to support a more complete restore workflow.
   ✅ This to make sure those resources are restored even if filters out by label from the resources list to restore

Does your change fix a particular issue?

vmware-tanzu#8816*
*temporary fix until the 1.17 refactor for resources depende\Summary of Changes:

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[weshayutin]

/retest

[weshayutin]

@amastbau Verifying goimports - failed! Please run 'make update'.
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_velero/379/pull-ci-openshift-velero-konveyor-dev-unit-test/1909956331075276800/artifacts/unit-test/unit/build-log.txt

[weshayutin]

@amastbau lint issues: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_velero/379/pull-ci-openshift-velero-konveyor-dev-lint/1909956331029139456/artifacts/lint/lint/build-log.txt

[weshayutin]

@mpryc FYI

[weshayutin]

test container based vm's restore via selector

All passed

Setup

• also using: Do not skip PVC when building VMIs resaources graph during restore item action. kubevirt/kubevirt-velero-plugin#349
  USING:
  unsupportedOverrides:
  kubevirtPluginImageFqin: quay.io/amastbau/kubevirt-velero-plugin:latest
  veleroImageFqin: quay.io/amastbau/velero:latest-l

BACKUP 3 cirros vm's

e.g. from vm-1

apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  annotations:
  generation: 1
  labels:
    app: cirros-test-cont-1
  name: cirros-test-cont-1
  namespace: cirros-test-cont
spec:
  dataVolumeTemplates:
  - metadata:
      annotations:
        cdi.kubevirt.io/storage.deleteAfterCompletion: "false"
      creationTimestamp: null
      name: cirros-test-cont-1-dv
    spec:
      pvc:
        accessModes:
        - ReadWriteOnce
        resources:
          requests:
            storage: 150Mi
        volumeMode: Block
      source:
        registry:
          pullMethod: node
          url: docker://quay.io/kubevirt/cirros-container-disk-demo
  running: true
  template:
    metadata:
      creationTimestamp: null
      name: cirros-test-cont-1
    spec:
      architecture: amd64
      domain:
        devices:
          disks:
          - disk:
              bus: virtio
            name: volume0
          interfaces:
          - masquerade: {}
            name: default
          rng: {}
        machine:
          type: q35
        resources:
          requests:
            memory: 256M
      networks:
      - name: default
        pod: {}
      terminationGracePeriodSeconds: 0
      volumes:
      - dataVolume:
          name: cirros-test-cont-1-dv
        name: volume0

backup results

backup describe https://termbin.com/ma7l

Nuke the vm's from orbit

oc delete -f cirros-test-1.yaml -f cirros-test-2.yaml -f cirros-test-3.yaml

Restore ALL

https://termbin.com/utox

Nuke all, restore 1 vm via selector

https://termbin.com/21vg

Nuke all, restore 1 vm ( second vm) via selector

https://termbin.com/shi2

[weshayutin]

/retest

[weshayutin]

@amastbau RUUUUUUN make update and push PLEASE!
These tests are defined here:
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/velero/openshift-velero-konveyor-dev.yaml#L29-L52

[amastbau]

/retest

[amastbau]

lint should be fine now

[mpryc]

/retest

[mpryc]

/retest

[amastbau]

/retest

[openshift-ci]

@amastbau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[weshayutin]

WOOOT!

[sseago]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amastbau, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[weshayutin]

/cherry-pick oadp-1.5

[openshift-cherrypick-robot]

@weshayutin: new pull request created: #381

Details

In response to this:

/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.