Core 1060 port separatemap page to ts #2766
Conversation
| } | ||
|
|
||
| function showTooltip(schoolInfo, flyThere) { | ||
| function showTooltip(schoolInfo: AugmentedInfo) { |
There was a problem hiding this comment.
Nothing was using flyThere
RoyEJohnson
force-pushed
the
core-1060-port-separatemap-page-to-ts
branch
from
56453ee to
10e14a0
Compare
| const mapZoom = isMobileDisplay() ? 2 : 3; | ||
| const map = React.useMemo( | ||
| () => new Map({ | ||
| () => createMap({ |
There was a problem hiding this comment.
Yikes. It wasn't a constructor.
| (event) => setInstitution(event.target.value), | ||
| [setInstitution] | ||
| ); | ||
| const options = [ |
There was a problem hiding this comment.
Having this defined inside the function was causing rerenders. This file is shown as changes in the first commit.
|
|
||
| .search-clear { | ||
| cursor: pointer; | ||
| appearance: none; |
There was a problem hiding this comment.
I changed it from a clickable icon with role="button" to a button element.
| function SearchAndClear({ | ||
| placeholder='Search by country, state, city, or institution name', | ||
| textValue='', | ||
| placeholder, |
There was a problem hiding this comment.
It's only called by one function, and that provides values for these parameters.
has Update result-box.tsx
RoyEJohnson
force-pushed
the
core-1060-port-separatemap-page-to-ts
branch
from
10e14a0 to
28b9816
Compare
| @@ -0,0 +1,152 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Changes in the first commit
| @@ -0,0 +1,61 @@ | |||
| import {useState, useEffect} from 'react'; | |||
There was a problem hiding this comment.
See first commit
| resultsOrSchool?.map((school) => | ||
| <ResultBox | ||
| model={school} totalCount={resultsOrSchool.length} key={school.pk} | ||
| model={school} key={school.pk} |
There was a problem hiding this comment.
Apparently the totalCount parameter went away some time ago in ResultBox.
There was a problem hiding this comment.
The test was subsumed by separatemap.test
RoyEJohnson
force-pushed
the
core-1060-port-separatemap-page-to-ts
branch
from
28b9816 to
8e617a0
Compare
There was a problem hiding this comment.
Test subsumed by new tests
There was a problem hiding this comment.
File diffs are in the first commit
CORE-1129
File changes are in the first commit. Tests are in the second commit. Prettier is the third.
I have annotated some unexpected changes. For files that show as deleted and created, you can see them as diffs in the first commit.