Core 1151 fix cookie yes gtm integration #2768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
core-1151-fix-cookie-yes-gtm-integration
branch
from
fdb52f0 to
8d32910
Compare
TomWoodward
approved these changes
Sep 8, 2025
Member
TomWoodward
left a comment
TomWoodward
left a comment
There was a problem hiding this comment.
this looks fine, looking at the diff i'm wondering if pardot and facebook also need to be updated
RoyEJohnson
force-pushed
the
core-1151-fix-cookie-yes-gtm-integration
branch
from
8d32910 to
7e829c7
Compare
Contributor
Author
Is GTM configured to load them as well? If so, it sounds like we can take them out of here at let it do its thing. |
RoyEJohnson
force-pushed
the
core-1151-fix-cookie-yes-gtm-integration
branch
from
7e829c7 to
dca5d10
Compare
Member
|
We would need to establish if they are currently loaded or not, but for them to be correctly not loaded based on the users consent settings we'd need to move them to gtm What do those vendor scripts do? |
RoyEJohnson
force-pushed
the
core-1151-fix-cookie-yes-gtm-integration
branch
from
9b2055d to
8cdc978
Compare
TomWoodward
requested changes
Sep 15, 2025
Member
TomWoodward
left a comment
TomWoodward
left a comment
There was a problem hiding this comment.
you're good to remove the pardot one as well
TomWoodward
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-1151