CORE-1206: Port errata-summary page to TypeScript #2772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
CORE-1206/port-errata-summary-to-typescript
branch
4 times, most recently
from
0698ec6 to
a32acdc
Compare
jivey
reviewed
Sep 15, 2025
RoyEJohnson
force-pushed
the
CORE-1206/port-errata-summary-to-typescript
branch
from
a32acdc to
fbec7ed
Compare
RoyEJohnson
reviewed
Sep 22, 2025
| setSortFn(colSpec.sortFn); | ||
| setSortKey(colSpec.id); | ||
| setSortDir(1); | ||
| const sortAttributes = React.useMemo(() => { |
There was a problem hiding this comment.
I changed this to only have onClick defined when sortable was set, which makes sense.
RoyEJohnson
reviewed
Sep 22, 2025
| // @ts-expect-error sortKey is guaranteed compatible with sortFn | ||
| sortFunctions[sortFn](a[sortKey], b[sortKey]) | ||
| const sortedData = [...data].sort((a, b) => | ||
| sortFunctions[sortFn](a[sortKey] as DisplayStatusValue, b[sortKey] as DisplayStatusValue) |
There was a problem hiding this comment.
These casts address TypeScript's complaints but honestly don't make a lot of sense to me. I don't see a way to use generics to fix it. TS considers the function parameters to necessarily be typed as DisplayStatusValue.
RoyEJohnson
reviewed
Sep 23, 2025
| const [sortFn, setSortFn] = useState<keyof typeof sortFunctions>('sortDate'); | ||
| const [sortKey, setSortKey] = useState<keyof ProcessedErrataItem>('date'); | ||
| const [sortDir, setSortDir] = useState<number>(-1); | ||
| const sortFunction = sortFunctions[sortFn]; |
There was a problem hiding this comment.
Moved more of the higher functionality here to centralize and abstract it.
jivey
approved these changes
Sep 23, 2025
Convert JavaScript modules to TypeScript (.js to .tsx): - errata-summary.js → errata-summary.tsx - hero/hero.js → hero/hero.tsx - table/table.js → table/table.tsx Added comprehensive TypeScript interfaces and type annotations: - Props interfaces for all React components - State type definitions for hooks - Detailed interfaces for errata data structures - Type-safe sort functions and controllers - Proper return type annotations 🤖 Generated with [Claude Code](https://claude.ai/code) Refine TypeScript implementation per code review feedback - Replace all 'any' types with specific type unions - Convert all interface definitions to type definitions - Fix line lengths to be ≤120 characters - Improve type safety for sort functions and errata data 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
RoyEJohnson
force-pushed
the
CORE-1206/port-errata-summary-to-typescript
branch
from
f1f28f3 to
e69aefa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports all JavaScript modules in the errata-summary page directory to TypeScript, changing file extensions from
.jsto.tsxand adding comprehensive type definitions.Files Converted
✅ Main Files Ported
src/app/pages/errata-summary/errata-summary.js→errata-summary.tsxsrc/app/pages/errata-summary/hero/hero.js→hero/hero.tsxsrc/app/pages/errata-summary/table/table.js→table/table.tsxTypeScript Improvements Added
🔧 Type Safety Enhancements
errata-summary.tsx:
RadioIteminterface for radio button configurationErrataDatainterface for data structureErrataSummaryPropsinterface for component propshero.tsx:
BookEntry,HeroData,HeroProps,HeroContentPropsPopTipProps,PopTipState,PopTipStyleResultinterfacesuseBookInfo,usePopTipStyle,usePopTipState)table.tsx:
ColumnSpecinterface for table column configurationRawErrataItemandProcessedErrataIteminterfaces for data transformationSortControllerinterface for sort functionality🚀 Benefits
Technical Details
Testing
The TypeScript compiler will validate all type annotations and catch potential issues. The dynamic import system (
ImportedPagecomponent) automatically resolves.tsxextensions.🤖 Generated with Claude Code