Port assignable page to TypeScript (CORE-1256) #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
reviewed
Sep 24, 2025
There was a problem hiding this comment.
Even in the first commit this was done as delete-and-create. There's not much here.
I had to move the dynamic imports to their own JS file because they break Jest.
RoyEJohnson
reviewed
Sep 24, 2025
There was a problem hiding this comment.
This and other "sections" files show as changes in the individual commits. Beyond adding types and formatting, nothing has changed in them.
RoyEJohnson
reviewed
Sep 24, 2025
There was a problem hiding this comment.
This is unrelated to the assignable page, but it's a change that needs to be made to a bunch of tests to make them quieter. I happened to refer to this file for some testing ideas.
jivey
approved these changes
Sep 30, 2025
- Convert 7 JavaScript files to TypeScript with comprehensive type definitions - Add proper prop typing for all React components following Roy's guidelines - Maintain existing functionality while adding type safety - Create test file with TypeScript type validation tests - Support complex nested data structures with proper typing Files converted: - assignable.js -> assignable.tsx (main page component) - sections/banner/banner.js -> banner.tsx - sections/about/about.js -> about.tsx - sections/courses/courses.js -> courses.tsx - sections/faq/faq.js -> faq.tsx - sections/overlapping-quote/overlapping-quote.js -> overlapping-quote.tsx - sections/cta/cta.js -> cta.tsx 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
RoyEJohnson
force-pushed
the
typescript-assignable-page
branch
from
8d88c35 to
f6b86b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Files converted
assignable.js->assignable.tsx(main page component with complete data type)sections/banner/banner.tsx(with image metadata and heading props)sections/about/about.tsx(with carousel image array typing)sections/courses/courses.tsx(with BookData and CourseList typing)sections/faq/faq.tsx(with FAQItem and accordion item typing)sections/overlapping-quote/overlapping-quote.tsx(with CTA props)sections/cta/cta.tsx(with link and button text props)Test plan
Resolves CORE-1256
🤖 Generated with Claude Code