-
Notifications
You must be signed in to change notification settings - Fork 5
Core 1268 review portal routing and tests #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
023ce21
fixed portal/adoption
RoyEJohnson 607b56d
Fix coverage on vertical-list
RoyEJohnson 65ab00a
Port portal-page-routes; code coverage for rex-portal
RoyEJohnson c3a932a
Coverage for contexts/portal
RoyEJohnson 7439359
test coverage for page-routes and portal-page-routes
RoyEJohnson 0b56cd3
Quiet Memory Router and a couple lint issues
RoyEJohnson 9554df4
Coverage for use-link-handler
RoyEJohnson a3897b7
Page-loaders
RoyEJohnson 61d1880
Remove piTracker test from shell
RoyEJohnson f9b5288
Reorder tests to avoid flaky failure
RoyEJohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove piTracker test from shell
- Loading branch information
commit 61d1880a2f5b28dfa1eecb5dfe853f9d4d004793
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tested in use-link-handler, and the test here is flaky.