Skip to content

Core-1277: Add 3 CTA buttons to Assignable landing page #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2025
Merged

Core-1277: Add 3 CTA buttons to Assignable landing page #2785

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2f6d43
Core-1277: Add 3 CTA buttons to Assignable landing page
RoyEJohnson Oct 9, 2025
eb522d7
Adjust layout within button-shaped
RoyEJohnson Oct 9, 2025
e22610c
Add ctaSectionFooter to banner
RoyEJohnson Oct 20, 2025
f8e5277
Merge branch 'main' into core-1277-add-links-to-assignable-landing-page
RoyEJohnson Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add ctaSectionFooter to banner
  • Loading branch information
@RoyEJohnson
RoyEJohnson committed Oct 29, 2025
commit e22610cef0a06c9a2e627a5184463a485f1362b0
2 changes: 1 addition & 1 deletion src/app/components/jsx-helpers/raw-html.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type RawHTMLArgs = {

export default function RawHTML({
Tag = 'div',
html,
html = '',
embed = false,
...otherProps
}: RawHTMLArgs) {
Expand Down
25 changes: 2 additions & 23 deletions src/app/pages/assignable/assignable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,9 @@ import {
FAQ,
CTA
} from './lazy-imports';
import type {BannerData} from './sections/banner/banner';
import './assignable.scss';

type ImageMeta = {
meta: {
downloadUrl: string;
};
};

type CarouselImage = {
image: {
file: string;
Expand All @@ -36,11 +31,7 @@ type FAQItem = {
answer: string;
};

type AssignablePageData = {
headingTitleImageUrl: string;
subheading: string;
headingDescription: string;
headingImage: ImageMeta;
type AssignablePageData = BannerData & {
section2Heading: string;
section2Description: string;
imageCarousel: [CarouselImage[]];
Expand All @@ -50,18 +41,6 @@ type AssignablePageData = {
comingSoonBooks: BookData[];
faqHeader: string;
faqs: FAQItem[];
addAssignableCtaHeader: string;
addAssignableCtaDescription: string;
addAssignableCtaLink: string;
addAssignableCtaButtonText: string;
instructorInterestCtaHeader: string;
instructorInterestCtaDescription: string;
instructorInterestCtaLink: string;
instructorInterestCtaButtonText: string;
instructorHelpCtaHeader: string;
instructorHelpCtaDescription: string;
instructorHelpCtaLink: string;
instructorHelpCtaButtonText: string;
assignableCtaText: string;
assignableCtaLink: string;
assignableCtaButtonText: string;
Expand Down
4 changes: 3 additions & 1 deletion src/app/pages/assignable/sections/banner/banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import useOptimizedImage, {
} from '~/helpers/use-optimized-image';
import './banner.scss';

type BannerData = {
export type BannerData = {
headingTitleImageUrl: string;
subheading: string;
headingDescription: string;
Expand All @@ -26,6 +26,7 @@ type BannerData = {
instructorHelpCtaDescription: string;
instructorHelpCtaLink: string;
instructorHelpCtaButtonText: string;
ctaSectionFooter: string;
};

export default function Banner({data}: {data: BannerData}) {
Expand Down Expand Up @@ -66,6 +67,7 @@ export default function Banner({data}: {data: BannerData}) {
linkText={data.instructorHelpCtaButtonText}
/>
</div>
<RawHTML className="text-content" html={data.ctaSectionFooter} />
</div>
</section>
);
Expand Down