Skip to content

Port takeover-dialog files to TypeScript #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 4, 2025
Merged

Port takeover-dialog files to TypeScript #2790

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cac4a4a
Port takeover-dialog JS files to TypeScript
OpenStaxClaude Oct 30, 2025
1db5f18
Define TakeoverData once; fix lint issues
RoyEJohnson Oct 30, 2025
9364a28
Tests
RoyEJohnson Oct 30, 2025
5325329
Coverage for phone-view
RoyEJohnson Oct 31, 2025
d1e123a
Remove overlapping-quote section from Assignable page
RoyEJohnson Oct 31, 2025
55ce981
Cover no PDF link case
RoyEJohnson Oct 31, 2025
f2f17cd
Prettier
RoyEJohnson Oct 31, 2025
dc3e721
De-optionalize fields
RoyEJohnson Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Coverage for phone-view
  • Loading branch information
@RoyEJohnson
RoyEJohnson committed Oct 31, 2025
commit 53253291db9f8ef74d3acbf04fd22328b2796c2c
4 changes: 4 additions & 0 deletions test/helpers/fetch-mocker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import booksData from '../src/data/books';
import booksForAnalyticsData from '../src/data/books-for-analytics';
import bookTitleData from '../src/data/book-titles';
import buyprintData from '../src/data/buyprint';
import chemistryData from '../src/data/chemistry-atoms-first.json';
Copy link
Contributor

@RoyEJohnson RoyEJohnson Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a book with a different book_state to test non-live book display

import donationPopupData from '../src/data/donation-popup';
import errataData from '../src/data/errata';
import errataBookData from '../src/data/errata-book';
Expand Down Expand Up @@ -68,6 +69,7 @@ global.fetch = jest.fn().mockImplementation((...args) => {
const isBooksForAnalytics = (/book_student_resources/).test(args[0]);
const isBookTitles = (/fields=title,id/).test(args[0]);
const isBuyprint = args[0].includes('buyprint');
const isChemistry = args[0].endsWith('pages/93/?format=json');
const isDonationPopup = args[0].includes('donation-popup');
const isErrata = (/pages\/errata\//).test(args[0]);
const isErrataBook = (/errata\/\?book_title/).test(args[0]);
Expand Down Expand Up @@ -131,6 +133,8 @@ global.fetch = jest.fn().mockImplementation((...args) => {
payload = blogMoreStories;
} else if (isBlogPinned) {
payload = blogPinned;
} else if (isChemistry) {
payload = chemistryData;
} else if (isDonationPopup) {
payload = donationPopupData;
} else if (isErrata) {
Expand Down
Loading