Skip to content

Add default to _after_request_fn #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosalberto merged 1 commit into from
Jun 8, 2018
Merged

Add default to _after_request_fn #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add default to _after_request_fn
  • Loading branch information
Gabriel Gravel committed Jun 8, 2018
commit 9bb85d5ea982469abc83163e5175da4164380e29
3 changes: 2 additions & 1 deletion flask_opentracing/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def _before_request_fn(self, attributes):

def _after_request_fn(self):
request = stack.top.request
span = self._current_spans.pop(request)
# the pop call can fail if the request is interrupted by a `before_request` method so we need a default
span = self._current_spans.pop(request, None)
if span is not None:
span.finish()