Skip to content

Fix the run_tests.py terminated with exception when timeout occurs. #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −2
Open

Fix the run_tests.py terminated with exception when timeout occurs. #3488

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ccace4
Fix the run_tests.py terminated with exception when timeout occurs.
yangwang201911 Jun 28, 2022
f7d7a1d
Update.
yangwang201911 Sep 13, 2022
19f9ff1
Update.
yangwang201911 Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update. 
Signed-off-by: Wang, Yang <[email protected]>
  • Loading branch information
@yangwang201911
yangwang201911 committed Sep 13, 2022
commit 19f9ff1052723573f676fa6dfbf6eea2ec9d4ceb
5 changes: 1 addition & 4 deletions demos/tests/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,14 +334,11 @@ def option_to_args(key, value):
demo.parse_output(output, test_case, device)
except (subprocess.CalledProcessError, subprocess.TimeoutExpired) as e:
output = e.output
if not isinstance(output, str):
output = e.output.decode('utf-8')
if isinstance(e, subprocess.CalledProcessError):
exit_msg = f'Exit code: {e.returncode}\n'
elif isinstance(e, subprocess.TimeoutExpired):
exit_msg = f'Command timed out after {e.timeout} seconds\n'
output += exit_msg
print(output)
print('{}\n{}'.format(output, exit_msg))
Copy link
Collaborator

@Wovchena Wovchena Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output var is used to save log file below: write_log(output, args.log_file). So you need this output += exit_msg.

If I understand correctly, TimeoutExpired.output is of bytes type for you. Maybe you can cast it to str before that +=

Please, add a comment to code with link to a bug https://bugs.python.org/issue43431 to explain why we have such cast.

Copy link
Author

@yangwang201911 yangwang201911 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, TimeoutExpired.output is of bytes type for you. Maybe you can cast it to str before that +=

Yes, you are right. output var is bytes type under that host env when timeout happened. While don't know why the output is Str type on my host when timeout happened.

Copy link
Collaborator

@Wovchena Wovchena Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the bug. It appears on python3.8+ may be you have python3.7 or 3.6 on your host

failed_tests.append(test_descr + '\n' + exit_msg)
num_failures += 1
execution_time = -1
Expand Down