Iterated-sha1: Don't accept raw ciphertexts except XSHA #5907
+19
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bare XSHA need to 46 chars of uppercase hex. Pot entries will still be iterated-sha1 canonical, tagged and in lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bare XSHA is exactly 46 chars of uppercase hex. Pot entries will currently be iterated-sha1 canonical, tagged and in lowercase.
I guess we should write XSHA entries to .pot using the raw uppercase format, like the XSHA-specific CPU format does? This will complicate valid a little and need adding a
split()but it's trivial. Working on it (slowly).