Docker for beta delivery #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating branch `docker` in this fork to date
Co-authored-by: vbrancat <[email protected]>
Co-authored-by: vbrancat <[email protected]>
Co-authored-by: Liang Yu <[email protected]>
Co-authored-by: Liang Yu <[email protected]>
Co-authored-by: Liang Yu <[email protected]>
Co-authored-by: Liang Yu <[email protected]>
…sujeong/COMPASS into eap_correction_into_s1_geocode_slc
LiangJYu
reviewed
Dec 21, 2022
vbrancat
approved these changes
Dec 21, 2022
vbrancat
left a comment
vbrancat
left a comment
There was a problem hiding this comment.
Thank you @seongsujeong, for this PR LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to modify the Dockerfile for the upcoming beta delivery. This PR needs to be submitted before cutting the release, so that the updated Dockerfile is included in the package.
This PR also includes the optimization of Docker image size. The changes can be found in the commit below.
seongsujeong@a5d1961
- [ ] Merge the changes in #46. Conflict is very likely, which needs to be resolved manuallyWait until that PR gets merged.s1-reader, etc.