Skip to content

Conversation

@estroz
Copy link
Member

@estroz estroz commented Aug 19, 2020

Description of the change:

  • internal/generate/clusterserviceversion: add CRD names that have conversion webhook configs matching a validating/mutating webhook config's service.

Motivation for the change: OLM supports conversion webhooks

/cc @varshaprasad96

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2020
@estroz
Copy link
Member Author

estroz commented Aug 19, 2020

Blocked by #3761

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2020
@estroz
Copy link
Member Author

estroz commented Nov 17, 2020

Closing this since the spec for a CSV's conversion webhooks has changed.

@estroz estroz closed this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants