Skip to content

feat: add option to set custom http.Client on HTTPRequester #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2022
Merged

feat: add option to set custom http.Client on HTTPRequester #335

merged 3 commits into from
Oct 10, 2022

Conversation

kirkeaton
Copy link
Contributor

@kirkeaton kirkeaton commented Jun 24, 2022 •
edited
Loading

Summary

@kirkeaton kirkeaton requested a review from a team as a code owner June 24, 2022 19:18
@msohailhussain
Copy link
Contributor

@kirkeaton There were few things missing, fixed in this PR.
#346

If you are fine, we can merge pr-346 or otherwise, please make those changes mentioned in the PR.
Also sign the CLA if you are planning to contribute in this repo. CLA link is here https://github.com/optimizely/go-sdk/blob/master/CONTRIBUTING.md

@kirkeaton
Copy link
Contributor Author

@msohailhussain I've incorporated the changes from #346 and I've signed the CLA.

msohailhussain
msohailhussain approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit 0a0d316 into optimizely:master Oct 10, 2022
@kirkeaton kirkeaton deleted the feat/custom-client branch October 10, 2022 19:07
@mnoman09 mnoman09 mentioned this pull request Oct 10, 2022
Merged
@kirkeaton kirkeaton mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kirkeaton kirkeaton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kirkeaton @msohailhussain