[FSSDK-11170] update: decision service methods for cmab #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to support CMAB UUID handling
…and include CMAB UUIDs in responses
…ils for CMAB configuration
…ations over CMAB service decisions in DecisionService
…tly verify error state
…izely and DecisionService
…text and related fetcher classes
muzahidul-opti
requested changes
Sep 25, 2025
| @Nullable ODPManager odpManager | ||
| ) { | ||
| @Nullable ODPManager odpManager, | ||
| @Nonnull CmabService cmabService |
There was a problem hiding this comment.
Looks like breaking change, can we make nullable?
| * @param options A list of options for decision-making. | ||
| * @return A decision result using traditional A/B testing logic only. | ||
| */ | ||
| OptimizelyDecision decideWithoutCmab(@Nonnull OptimizelyUserContext user, |
There was a problem hiding this comment.
I think we can rename it as decideSync
| * @param options A list of options for decision-making. | ||
| * @return All decision results mapped by flag keys, using traditional A/B testing logic only. | ||
| */ | ||
| Map<String, OptimizelyDecision> decideForKeysWithoutCmab(@Nonnull OptimizelyUserContext user, |
There was a problem hiding this comment.
Need to rename the method
| * @param options A list of options for decision-making. | ||
| * @return All decision results mapped by flag keys, using traditional A/B testing logic only. | ||
| */ | ||
| Map<String, OptimizelyDecision> decideAllWithoutCmab(@Nonnull OptimizelyUserContext user, |
| private String cmabUUID; | ||
|
|
||
| public DecisionResponse(@Nullable T result, @Nonnull DecisionReasons reasons) { | ||
| public DecisionResponse(@Nullable T result, @Nonnull DecisionReasons reasons, @Nonnull boolean error, @Nullable String cmabUUID) { |
There was a problem hiding this comment.
Does it impact the existing user?
| String experimentKey = experiment.getKey(); | ||
| String combinedBucketId = bucketingId + experimentId; | ||
|
|
||
| // Handle CMAB traffic allocation |
There was a problem hiding this comment.
Shouldn't we check mutex rules here?
| Group experimentGroup = projectConfig.getGroupIdMapping().get(groupId); | ||
|
|
||
| if (experimentGroup.getPolicy().equals(Group.RANDOM_POLICY)) { | ||
| Experiment bucketedExperiment = bucketToExperiment(experimentGroup, bucketingId, projectConfig); |
There was a problem hiding this comment.
Oh I see, mutex is checking here.
| public int hashCode() { | ||
| int result = variation != null ? variation.hashCode() : 0; | ||
| result = 31 * result + (decisionSource != null ? decisionSource.hashCode() : 0); | ||
| result = 31 * result + (cmabUUID != null ? cmabUUID.hashCode() : 0); |
There was a problem hiding this comment.
Curious to know, what is the significant of 31 here?
| * AsyncDecisionsFetcher handles asynchronous decision fetching for multiple flag keys. | ||
| * This class follows the same pattern as ODP's async segment fetching. | ||
| */ | ||
| public class AsyncDecisionsFetcher extends Thread { |
There was a problem hiding this comment.
Can we shift the code into AysncDecisionFeatcher ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Decision Service methods to handle CMAB
Test plan
Added unit tests
Issues
FSSDK-11170