Skip to content

chore(ci): replace node target with v9/v10.0 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2018
Merged

chore(ci): replace node target with v9/v10.0 #101

merged 2 commits into from
May 21, 2018

Conversation

tylerbrandt
Copy link
Contributor

@tylerbrandt tylerbrandt commented May 19, 2018 •
edited
Loading

Travis is erroring (example) when the "node" or "10" target is given, but the tests are passing with node 10 (at least on my machine). Update "node" targets to "9"/"10.0" until this is resolved.

$ node --version
v10.0.0
$ npm run test-travis

> @optimizely/[email protected] test-travis /Users/tbrandt/optly/Projects/javascript-sdk/packages/optimizely-sdk
> npm run test && grunt
...
  362 passing (653ms)

Mitigation for #102

mikeproeng37
mikeproeng37 approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tylerbrandt tylerbrandt mentioned this pull request May 21, 2018
Merged
@tylerbrandt
Copy link
Contributor Author

NVM, it's not a Travis CI thing. [email protected] is fine but [email protected] reproduces the errors, on my system.

@tylerbrandt tylerbrandt changed the title chore(ci): replace node target with v9 chore(ci): replace node target with v9/v10.0 May 21, 2018
mikeproeng37
mikeproeng37 approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@tylerbrandt tylerbrandt merged commit ba57b53 into master May 21, 2018
@tylerbrandt tylerbrandt deleted the tyler/explicit-node branch May 21, 2018 18:08
@spencerwilson-optimizely spencerwilson-optimizely mentioned this pull request Jul 3, 2018
Merged
spencerwilson-optimizely added a commit that referenced this pull request Jul 3, 2018
@spencerwilson-optimizely
chore(ci): Restore Node.js 10.x to Travis matrix (#142)
ff624de 
## Summary

- Re-enable CI against latest Node.js 10.x release

It was disabled in #101, but from the [example failure](https://travis-ci.org/optimizely/javascript-sdk/jobs/380942404) given in that PR, I suspect the bug lies in lerna. No matter now, since lerna has been bypassed since #129.

## Test plan
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tylerbrandt @mikeproeng37