Skip to content

fix(decision-service): Adds bucketing id in getVariationForRollout method. #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 14, 2019
Merged

fix(decision-service): Adds bucketing id in getVariationForRollout method. #200

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
046db6c
Adds getBucketingId call in getVariationForRollout method.
mfahadahmed Dec 14, 2018
4baaf44
Merge branch 'master' into fahad/bucketing-id-fix
mikeproeng37 Dec 21, 2018
41e7784
Merge branch 'master' into fahad/bucketing-id-fix
mikeproeng37 Jan 10, 2019
9dccbc9
Add unit tests.
mfahadahmed Jan 11, 2019
ea1cbfe
Merge branch 'master' into fahad/bucketing-id-fix
mikeproeng37 Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/optimizely-sdk/lib/core/decision_service/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,8 @@ DecisionService.prototype._getVariationForRollout = function(feature, userId, at
};
}

var bucketingId = this._getBucketingId(userId, attributes);

// The end index is length - 1 because the last experiment is assumed to be
// "everyone else", which will be evaluated separately outside this loop
var endIndex = rollout.experiments.length - 1;
Expand All @@ -401,7 +403,7 @@ DecisionService.prototype._getVariationForRollout = function(feature, userId, at
}

this.logger.log(LOG_LEVEL.DEBUG, sprintf(LOG_MESSAGES.USER_MEETS_CONDITIONS_FOR_TARGETING_RULE, MODULE_NAME, userId, index + 1));
bucketerParams = this.__buildBucketerParams(experiment.key, userId, userId);
bucketerParams = this.__buildBucketerParams(experiment.key, bucketingId, userId);
variationId = bucketer.bucket(bucketerParams);
variation = this.configObj.variationIdMap[variationId];
if (variation) {
Expand Down