fix (datafile manager) [OASIS-4715]: Rename top-level exports to avoid conflict with interface name #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2019 15:54
HttpPollingDatafileManager in all import names/class declarations
jordangarcia
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The interface
DatafileManager, defined in src/datafileManager.ts, is exported from src/index.node.ts and src/index.browser.ts.However, in each of these top-level entry points, another export statement appears below, which exports something else (the actual implementation of the datafile manager), using the same name.
To avoid the name conflict, we rename the exports of the datafile manager implementations from
DatafileManagertoHttpPollingDatafileManager.Test plan
Updated unit tests
Issues
https://optimizely.atlassian.net/browse/OASIS-4715