Skip to content

feat (utils): Add notification types to utils package #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2019
Merged

feat (utils): Add notification types to utils package #321

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c98a5bf
Add notification types as an enum in utils
Aug 7, 2019
7080436
Add log event notification type
Aug 7, 2019
2f01faf
Add comment for new notification type
Aug 7, 2019
a97dea6
Capitalize Object
Aug 7, 2019
f2d6fa4
Add NotificationCenter interface
Aug 7, 2019
eec268c
Fix language - will be sent, not was sent
Aug 7, 2019
8354f15
Update changelog
Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix language - will be sent, not was sent
  • Loading branch information
Matt Carroll committed Aug 7, 2019
commit eec268cb8c16cf54997716b371a5fe24d7ef6d2d
2 changes: 1 addition & 1 deletion packages/utils/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export function sprintf(format: string, ...args: any[]): string {
* - decisionInfo {Object|undefined}
*
* LOG_EVENT: A batch of events, which could contain impressions and/or conversions,
* was sent to Optimizely
* will be sent to Optimizely
* Callbacks will receive an object argument with the following properties:
* - url {string}
* - httpVerb {string}
Expand Down