Skip to content

fix: Added logger for react native which uses console.warn for error #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2019
Merged

fix: Added logger for react native which uses console.warn for error #360

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d97c0c
Added logger for react native which uses console.warn for error
zashraf1985 Oct 3, 2019
f3df4a1
1. Reverted changes from logging package.
zashraf1985 Oct 6, 2019
2f3e7c4
made react native entry point independent of browser entry
zashraf1985 Oct 7, 2019
a640d79
added copyright information and unit tests
zashraf1985 Oct 8, 2019
6f933ce
Fixed licensing info and remove a few unrelated unit tests
zashraf1985 Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed licensing info and remove a few unrelated unit tests
  • Loading branch information
@zashraf1985
zashraf1985 committed Oct 9, 2019
commit 6f933ce8fc9597eb7220acd0d8e442ccb88db695
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/index.react_native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2016-2017, 2019, Optimizely
* Copyright 2019, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
163 changes: 1 addition & 162 deletions packages/optimizely-sdk/lib/index.react_native.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2016-2019, Optimizely
* Copyright 2019, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -131,167 +131,6 @@ describe('javascript-sdk/react-native', function() {
assert.strictEqual(activate, 'control');
});

it('should be able to set and get a forced variation', function() {
var optlyInstance = optimizelyFactory.createInstance({
datafile: testData.getTestProjectConfig(),
errorHandler: fakeErrorHandler,
eventDispatcher: optimizelyFactory.eventDispatcher,
logger: silentLogger,
});

var didSetVariation = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'control');
assert.strictEqual(didSetVariation, true);

var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
assert.strictEqual(variation, 'control');
});

it('should be able to set and unset a forced variation', function() {
var optlyInstance = optimizelyFactory.createInstance({
datafile: testData.getTestProjectConfig(),
errorHandler: fakeErrorHandler,
eventDispatcher: optimizelyFactory.eventDispatcher,
logger: silentLogger,
});

var didSetVariation = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'control');
assert.strictEqual(didSetVariation, true);

var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
assert.strictEqual(variation, 'control');

var didSetVariation2 = optlyInstance.setForcedVariation('testExperiment', 'testUser', null);
assert.strictEqual(didSetVariation2, true);

var variation2 = optlyInstance.getForcedVariation('testExperiment', 'testUser');
assert.strictEqual(variation2, null);
});

it('should be able to set multiple experiments for one user', function() {
var optlyInstance = optimizelyFactory.createInstance({
datafile: testData.getTestProjectConfig(),
errorHandler: fakeErrorHandler,
eventDispatcher: optimizelyFactory.eventDispatcher,
logger: silentLogger,
});

var didSetVariation = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'control');
assert.strictEqual(didSetVariation, true);

var didSetVariation2 = optlyInstance.setForcedVariation(
'testExperimentLaunched',
'testUser',
'controlLaunched'
);
assert.strictEqual(didSetVariation2, true);

var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
assert.strictEqual(variation, 'control');

var variation2 = optlyInstance.getForcedVariation('testExperimentLaunched', 'testUser');
assert.strictEqual(variation2, 'controlLaunched');
});

it('should be able to set multiple experiments for one user, and unset one', function() {
var optlyInstance = optimizelyFactory.createInstance({
datafile: testData.getTestProjectConfig(),
errorHandler: fakeErrorHandler,
eventDispatcher: optimizelyFactory.eventDispatcher,
logger: silentLogger,
});

var didSetVariation = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'control');
assert.strictEqual(didSetVariation, true);

var didSetVariation2 = optlyInstance.setForcedVariation(
'testExperimentLaunched',
'testUser',
'controlLaunched'
);
assert.strictEqual(didSetVariation2, true);

var didSetVariation2 = optlyInstance.setForcedVariation('testExperimentLaunched', 'testUser', null);
assert.strictEqual(didSetVariation2, true);

var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
assert.strictEqual(variation, 'control');

var variation2 = optlyInstance.getForcedVariation('testExperimentLaunched', 'testUser');
assert.strictEqual(variation2, null);
});

it('should be able to set multiple experiments for one user, and reset one', function() {
var optlyInstance = optimizelyFactory.createInstance({
datafile: testData.getTestProjectConfig(),
errorHandler: fakeErrorHandler,
eventDispatcher: optimizelyFactory.eventDispatcher,
logger: silentLogger,
});

var didSetVariation = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'control');
assert.strictEqual(didSetVariation, true);

var didSetVariation2 = optlyInstance.setForcedVariation(
'testExperimentLaunched',
'testUser',
'controlLaunched'
);
assert.strictEqual(didSetVariation2, true);

var didSetVariation2 = optlyInstance.setForcedVariation(
'testExperimentLaunched',
'testUser',
'variationLaunched'
);
assert.strictEqual(didSetVariation2, true);

var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
assert.strictEqual(variation, 'control');

var variation2 = optlyInstance.getForcedVariation('testExperimentLaunched', 'testUser');
assert.strictEqual(variation2, 'variationLaunched');
});

it('should override bucketing when setForcedVariation is called', function() {
var optlyInstance = optimizelyFactory.createInstance({
datafile: testData.getTestProjectConfig(),
errorHandler: fakeErrorHandler,
eventDispatcher: optimizelyFactory.eventDispatcher,
logger: silentLogger,
});

var didSetVariation = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'control');
assert.strictEqual(didSetVariation, true);

var variation = optlyInstance.getVariation('testExperiment', 'testUser');
assert.strictEqual(variation, 'control');

var didSetVariation2 = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'variation');
assert.strictEqual(didSetVariation2, true);

var variation = optlyInstance.getVariation('testExperiment', 'testUser');
assert.strictEqual(variation, 'variation');
});

it('should override bucketing when setForcedVariation is called for a not running experiment', function() {
var optlyInstance = optimizelyFactory.createInstance({
datafile: testData.getTestProjectConfig(),
errorHandler: fakeErrorHandler,
eventDispatcher: optimizelyFactory.eventDispatcher,
logger: silentLogger,
});

var didSetVariation = optlyInstance.setForcedVariation(
'testExperimentNotRunning',
'testUser',
'controlNotRunning'
);
assert.strictEqual(didSetVariation, true);

var variation = optlyInstance.getVariation('testExperimentNotRunning', 'testUser');
assert.strictEqual(variation, null);
});

describe('when passing in logLevel', function() {
beforeEach(function() {
sinon.stub(logging, 'setLogLevel');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/plugins/logger/index.react_native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2016-2017, Optimizely
* Copyright 2019, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/plugins/logger/index.react_native.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2016, Optimizely
* Copyright 2019, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down