Skip to content

fix: impression event attributes exp, var should be empty instead of null #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2021
Merged

fix: impression event attributes exp, var should be empty instead of null #718

merged 4 commits into from
Nov 3, 2021

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Nov 3, 2021 •
edited by zashraf1985
Loading

Summary

  • experimentId and variationId should be empty if no variation or experiment is found.

Test plan

  • Manually tested
  • All tests pass

@msohailhussain msohailhussain requested a review from a team as a code owner November 3, 2021 19:56
zashraf1985
zashraf1985 approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a NIT!

@coveralls
Copy link

coveralls commented Nov 3, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 97.155% when pulling 8112b1b on sohail/ep_fix into f2a711c on master.

@zashraf1985 zashraf1985 merged commit 247e91c into master Nov 3, 2021
@zashraf1985 zashraf1985 deleted the sohail/ep_fix branch November 3, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@msohailhussain msohailhussain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msohailhussain @coveralls @zashraf1985