Skip to content

Use TYPE_CHECKING in visualization/_terminator_improvement.py#6579

Merged
not522 merged 1 commit into
optuna:masterfrom
saivedant169:refactor/type-checking-viz-terminator
Mar 26, 2026
Merged

Use TYPE_CHECKING in visualization/_terminator_improvement.py#6579
not522 merged 1 commit into
optuna:masterfrom
saivedant169:refactor/type-checking-viz-terminator

Conversation

@saivedant169
Copy link
Copy Markdown
Contributor

Part of #6029.

Moved Study into TYPE_CHECKING. Only used in type annotations, not at runtime.

ruff check --select TCH passes clean.

Only used in type annotations, not at runtime.

Part of optuna#6029
@not522 not522 changed the title Use TYPE_CHECKING in visualization/_terminator_improvement.py Use TYPE_CHECKING in visualization/_terminator_improvement.py Mar 26, 2026
Copy link
Copy Markdown
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@not522 not522 added the code-fix Change that does not change the behavior, such as code refactoring. label Mar 26, 2026
@not522 not522 added this to the v4.9.0 milestone Mar 26, 2026
@not522 not522 merged commit 22e5833 into optuna:master Mar 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants