Skip to content

libbpftune: mark netns as _GONE if we cannot setns() #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-maguire merged 1 commit into from
Nov 20, 2024
Merged

libbpftune: mark netns as _GONE if we cannot setns() #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/libbpftune.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,6 +1151,13 @@ int bpftuner_tunable_sysctl_write(struct bpftuner *tuner, unsigned int tunable,

for (i = 0; i < t->desc.num_values; i++)
t->current_values[i] = values[i];
} else if (ret < 0) {
/* If sysctl update failed, mark non-global netns as gone to
* avoid repeated attempts to update it.
*/
if (netns && netns->netns_cookie &&
netns->netns_cookie != global_netns_cookie)
netns->state = BPFTUNE_GONE;
}

if (fd > 0)
Expand Down Expand Up @@ -1409,13 +1416,17 @@ int bpftuner_netns_fd_from_cookie(struct bpftuner *tuner, unsigned long cookie)
{
struct bpftuner_netns *netns = bpftuner_netns_from_cookie(tuner->id,
cookie);
int fd;

if (netns && netns->state >= BPFTUNE_MANUAL) {
bpftune_log(LOG_DEBUG, "netns (cookie %ld} manually disabled\n",
cookie);
return -ENOENT;
}
return bpftune_netns_find(cookie);
fd = bpftune_netns_find(cookie);
if (fd > 0 && !netns)
bpftuner_netns_init(tuner, cookie);
return fd;
}

int bpftune_netns_init_all(void)
Expand Down