libbpftune: support quiet mode for bpftune_netns_set() #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when matching netns cookies with netns, we iterate over all netns and setns() to retrieve the cookie. This can fail but currently we dump error messages in such cases. Error messaging should be reserved for the case where we are entering the netns to either read or write sysctls. So add a bool quiet param to bpftune_netns_set(). Signed-off-by: Alan Maguire <[email protected]> Reported-by: Rob Landers <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when matching netns cookies with netns, we iterate over all netns and setns() to retrieve the cookie. This can fail but currently we dump error messages in such cases. Error messaging should be reserved for the case where we are entering the netns to either read or write sysctls. So add a bool quiet param to bpftune_netns_set().
Reported-by: Rob Landers [email protected]