Skip to content

libbpftune: only send events to active tuners #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-maguire merged 1 commit into from
Nov 25, 2024
Merged

libbpftune: only send events to active tuners #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
libbpftune: only send events to active tuners 
Roger reported a segmentation fault in tcp_buffer_tuner. Examining the
state of the tuner we were handling an event when in manual (i.e. off)
state.  The event handler for a tuner should only be called if the tuner
is active.

Reported by: Roger Knobbe (https://github.com/rknobbe)
Signed-off-by: Alan Maguire <[email protected]>
  • Loading branch information
@alan-maguire
alan-maguire committed Nov 25, 2024
commit 2c530fd99bba0721d86a644214e255e98d6a3d9d
4 changes: 3 additions & 1 deletion src/libbpftune.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,9 @@ static int bpftune_ringbuf_event_read(void *ctx, void *data, size_t size)
event->netns_cookie,
event->netns_cookie && event->netns_cookie != global_netns_cookie ?
"non-global netns" : "global netns");
tuner->event_handler(tuner, event, ctx);
/* only send events to active tuners */
if (tuner->state == BPFTUNE_ACTIVE)
tuner->event_handler(tuner, event, ctx);

return 0;
}
Expand Down