Nsfixes2 #111
Merged
Nsfixes2 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we change a sysctl external to bpftune, the aim is to disable the auto-tuning for the associated namespace. however in the global ns we were disabling tuning for global and non-global namespaces via bpftuner_fini(). Ensure we disable global namespace only, and that we only send events for tuners that are enabled and - if namespaced - if the namespace is enabled also. Reported by: Roger Knobbe (https://github.com/rknobbe) Signed-off-by: Alan Maguire <[email protected]>
this will help diagnose the cause of sysctl changes that disable auto-tuning. Signed-off-by: Alan Maguire <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes around non-global network namespaces and sysctl-based disable when external entity changes a sysctl we manage. prior to these fixes we were disabling non-global ns when the global ns was switched off; these changes ensure non-global ns can still work when global has been disabled. also add the name of the process that triggered the disable for better diagnosis.