Skip to content

libbpftune: fix bpftune_netns_info() checks when searching for netns … #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-maguire merged 1 commit into from
Nov 28, 2024
Merged

libbpftune: fix bpftune_netns_info() checks when searching for netns … #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
libbpftune: fix bpftune_netns_info() checks when searching for netns … 
…cookie

netns cookie check does not verify cookie is the one we are looking for;
this means we match first cookie we find and misapply changes when
multiple netns are in place.

Reported-by: Roger Knobbe <https://github.com/rknobbe>
Signed-off-by: Alan Maguire <[email protected]>
  • Loading branch information
@alan-maguire
alan-maguire committed Nov 28, 2024
commit e03edfc99235b448bd577e4afb02fd3e8404b3cc
3 changes: 2 additions & 1 deletion src/libbpftune.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,7 +1487,8 @@ static int bpftune_netns_find(unsigned long cookie)
mntfd = open(ent->mnt_dir, O_RDONLY);
if (mntfd < 0)
continue;
if (bpftune_netns_info(0, &mntfd, &netns_cookie)) {
if (bpftune_netns_info(0, &mntfd, &netns_cookie) ||
(cookie && netns_cookie != cookie)) {
close(mntfd);
continue;
}
Expand Down