Skip to content

sysctl_tuner: log pid for sysctl modification #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-maguire merged 1 commit into from
Jul 25, 2023
Merged

sysctl_tuner: log pid for sysctl modification #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
sysctl_tuner: log pid for sysctl modification 
good to know who is changing sysctls when we disable tuner; log pid.

Signed-off-by: Alan Maguire <[email protected]>
  • Loading branch information
@alan-maguire
alan-maguire committed Jul 25, 2023
commit f78916adb55fad00861ed8bbce32d0a2e5c09be5
1 change: 1 addition & 0 deletions src/sysctl_tuner.bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ int BPF_KPROBE(bpftune_sysctl, struct ctl_table_header *head,
net = (void *)root -
(__u64)__builtin_preserve_access_index(&dummy_net->sysctls) -
(__u64)__builtin_preserve_access_index(&dummy_ctl_table_set->dir);
event.pid = current_pid;
event.netns_cookie = get_netns_cookie(net);
if (event.netns_cookie == (unsigned long)-1)
return 0;
Expand Down
4 changes: 2 additions & 2 deletions src/sysctl_tuner.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ void event_handler(struct bpftuner *tuner, struct bpftune_event *event,
*/
if (strstr(path, event->str)) {
bpftune_log(BPFTUNE_LOG_LEVEL,
"user modified sysctl '%s' that tuner '%s' uses; disabling '%s' for namespace cookie %ld\n",
event->str, t->name, t->name,
"user (pid %ld) modified sysctl '%s' that tuner '%s' uses; disabling '%s' for namespace cookie %ld\n",
event->pid, event->str, t->name, t->name,
event->netns_cookie);
bpftuner_netns_fini(t, event->netns_cookie, BPFTUNE_MANUAL);
break;
Expand Down