Skip to content

libbpftune: do not print error when signal received #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-maguire merged 1 commit into from
Aug 21, 2023
Merged

libbpftune: do not print error when signal received #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
libbpftune: do not print error when signal received 
when we get a signal during polling, we see

Aug 19 10:11:41 nixos-dell bpftune[7957]: ring_buffer__poll: Interrupted system call

This is not an error; it's just that the signal is delivered while
we are polling, so skip error display for this case.

Reported by: Tungsten842 (https://github.com/Tungsten842)
Signed-off-by: Alan Maguire <[email protected]>
  • Loading branch information
@alan-maguire
alan-maguire committed Aug 21, 2023
commit 8a4c0996bb47c507938766e77b67302f8edc9dd6
4 changes: 3 additions & 1 deletion src/libbpftune.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,9 @@ int bpftune_ring_buffer_poll(void *ring_buffer, int interval)
while (!ring_buffer_done) {
err = ring_buffer__poll(rb, interval);
if (err < 0) {
bpftune_log_bpf_err(err, "ring_buffer__poll: %s\n");
/* -EINTR means we got signal; don't report as error. */
if (err != -EINTR)
bpftune_log_bpf_err(err, "ring_buffer__poll: %s\n");
break;
}
}
Expand Down