bpftune: support rollback mode (-R) for bpftune #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support rollback mode where if bpftune is run with -R option, we roll back sysctl settings on exit. Log will show us a summary of changes along with the values were rolled back; for example: Aug 23 19:15:04 bpf bpftune[360835]: sysctl 'net.ipv4.tcp_wmem' changed from (4096 16384 16384 ) -> (4096 16384 2220415 ) Aug 23 19:15:04 bpf bpftune[360835]: Scenario 'need to increase TCP buffer size(s)' occurred for tunable 'net.ipv4.tcp_wmem' in global ns. Need to increase buffer size(s) to maximize throughput Aug 23 19:15:04 bpf bpftune[360835]: Rolling back sysctl values for 'net.ipv4.tcp_wmem' from (4096 16384 2220415 ) to original values (4096 16384 16384 )... Signed-off-by: Alan Maguire <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support rollback mode where if bpftune is run with -R option, we roll back sysctl settings on exit. Log will show us a summary of changes along with the values were rolled back; for example:
Aug 23 19:15:04 bpf bpftune[360835]: sysctl 'net.ipv4.tcp_wmem' changed from (4096 16384 16384 ) -> (4096 16384 2220415 )
Aug 23 19:15:04 bpf bpftune[360835]: Scenario 'need to increase TCP buffer size(s)' occurred for tunable 'net.ipv4.tcp_wmem' in global ns. Need to increase buffer size(s) to maximize throughput
Aug 23 19:15:04 bpf bpftune[360835]: Rolling back sysctl values for 'net.ipv4.tcp_wmem' from (4096 16384 2220415 ) to original values (4096 16384 16384 )...