Skip to content

tcp_conn_tuner: remove unneeded debug messages #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-maguire merged 1 commit into from
Sep 5, 2023
Merged

tcp_conn_tuner: remove unneeded debug messages #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tcp_conn_tuner: remove unneeded debug messages 
we have events + summary on exit

Signed-off-by: Alan Maguire <[email protected]>
  • Loading branch information
@alan-maguire
alan-maguire committed Sep 5, 2023
commit 5ab9b69c4bc2973041225039f69d0f2c56d7af02
10 changes: 0 additions & 10 deletions src/tcp_conn_tuner.bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,6 @@ int conn_tuner_sockops(struct bpf_sock_ops *ops)
for (i = 0; i < NUM_TCP_CONN_METRICS; i++) {
cands[i] = 0;
metric_value = remote_host->metrics[i].metric_value;
bpftune_debug("conn_tuner: addr 0x%x cong '%s' metric_value %lld\n",
ops->remote_ip4, congs[i], metric_value);

if (metric_value > metric_min)
continue;
else if (metric_value < metric_min) {
Expand Down Expand Up @@ -171,15 +168,8 @@ int conn_tuner_sockops(struct bpf_sock_ops *ops)
minindex &= (NUM_TCP_CONN_METRICS - 1);
/* choose random alg 5% of the time (1/20) */
s = epsilon_greedy(minindex, NUM_TCP_CONN_METRICS, 20);
if (s != minindex) {
bpftune_debug("conn_tuner: choose state %d instead of greedy state %d\n",
s, minindex);
metric_min = 0;
}
s &= 0x3;

bpftune_debug("conn_tuner: setting cong alg '%s' for 0x%x, metric_min %ld\n",
congs[s], ops->remote_ip4, metric_min);
set_cong(ops, remote_host, s);

return 1;
Expand Down