fix: Token.CharData should check underlying event type

[costela]

Checking the type of the token compiles and partially works because both event types and token types share a type and gosax.EventText == xmllb.CharData.

Fixes #15

[orisano]

Could you describe the specific cases where you’re running into problems?

[costela]

Sure! Just using the example code can lead to this:

tok, err := d.Token()
//...
switch tok.Type() {
/...
case xmlb.CharData: // ⚠️ this is also the case for gosax.EventCData
	t, _ := tok.CharData()
	fmt.Println("CharData", string(t)) // 💥 this prints <![CDATA...
}

The code above prints the <![CDATA content, even though CharData tries to remove it, because the gosax.EventCData case in that method can never be true (unless you're calling tok.CharData on a Token with Type() == ProcInst, since then - by chance - xmlb.ProcInst == gosax.EventCData).

[costela]

I can create an issue if you want to have a clearer trail for future reference.

[orisano]

I can create an issue if you want to have a clearer trail for future reference.

pls!

[costela]

done: #15

[orisano]

thanks!

[costela]

Thanks for merging! 🙇🏻
Any chance we can get a new tag with the fix?

[orisano]

https://github.com/orisano/gosax/releases/tag/v1.1.4 released!