Skip to content

chore: make changes to satisfy eslint rules #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melloware merged 6 commits into from
Oct 31, 2025
Merged

chore: make changes to satisfy eslint rules #2517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b78112
add type:module to sample packages
snebjorn Oct 26, 2025
5f7f1c7
chore: make changes to satisfy eslint rules
snebjorn Oct 28, 2025
8184905
ci: run linting in selected packages
snebjorn Oct 30, 2025
aed43b1
fixed failed zod tests
snebjorn Oct 30, 2025
0a065b4
reverted some changes where the type were misleading
snebjorn Oct 30, 2025
fd95862
fix typo
snebjorn Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reverted some changes where the type were misleading
  • Loading branch information
@snebjorn
snebjorn committed Oct 30, 2025
commit 0a065b4ba23491eaa474cd5826619f098ddbd560
4 changes: 3 additions & 1 deletion packages/mock/src/faker/getters/combine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ export const combineSchemasMock = ({
let finalValue =
value === 'undefined'
? value
: `${value}${separator === 'allOf' ? '' : '])'}`;
: // containsOnlyPrimitiveValues isn't just true, it's being set to false inside the above reduce and the type system doesn't detect it
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
`${separator === 'allOf' && !containsOnlyPrimitiveValues ? '{' : ''}${value}${separator === 'allOf' ? (containsOnlyPrimitiveValues ? '' : '}') : '])'}`;
if (itemResolvedValue) {
finalValue = finalValue.startsWith('...')
? `...{${finalValue}, ${itemResolvedValue.value}}`
Expand Down
1 change: 1 addition & 0 deletions packages/mock/src/faker/getters/scalar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ const getEnum = (
) => {
if (!item.enum) return '';
const joinedEnumValues = item.enum
.filter((e) => e !== null) // TODO fix type, e can absolutely be null
.map((e) =>
type === 'string' || (type === undefined && typeof e === 'string')
? `'${escape(e)}'`
Expand Down
1 change: 0 additions & 1 deletion packages/mock/src/faker/resolvers/value.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {
type ContextSpecs,
type GeneratorImport,
getPropertySafe,
getRefInfo,
isReference,
isRootKey,
Expand Down