New policies #19
Merged
New policies #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks that file exists and is not empty. Issue action supported, Fix action to be added in the future
Policy to disallow outside collaborators with admin or push access.
This is the first policy that uses a scorecard check. Needed to move to v32 of go-github to match scorecard. Future go-github should allow easy conversion.
| if err != nil { | ||
| t.Fatalf("Unexpected error: %v", err) | ||
| } | ||
| if !reflect.DeepEqual(res, &test.Exp) { |
There was a problem hiding this comment.
Consider using github.com/google/go-cmp/cmp here.
azeemshaikh38
previously approved these changes
Jul 23, 2021
Member
Author
|
@azeemshaikh38 @laurentsimon Can I get this re-approved ( I have dismiss stale turned on ) |
azeemshaikh38
approved these changes
Jul 26, 2021
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3 new policies to allstar.
Note: moving to an older version of go-github to match scorecard until google/go-github#2016 is released.