Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Do not process types
  • Loading branch information
deniskoronchik committed Oct 30, 2021
commit 2591cc4b05f0ee909decb8dce24deae7b12eaadd
14 changes: 0 additions & 14 deletions db/sc/scs/parser_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@ def __init__(self) -> None:
# Counter for generated names
self._names_counter = 0

# Set of type keynodes (for fast access)
self._type_keynodes = set()
self._type_keynodes.update(KeynodeNames.CORE_TYPES)
self._type_keynodes.update(KeynodeNames.CONST_TYPES)
self._type_keynodes.update(KeynodeNames.NODE_TYPES)
self._type_keynodes.update(KeynodeNames.ARC_PERM_TYPES)
self._type_keynodes.update(KeynodeNames.ARC_POS_TYPES)

# Dictionary of alias definitions <str, AliasDefinition>
self._aliases = {}

Expand Down Expand Up @@ -139,12 +131,6 @@ def _new_warning(self, ctx: TokenContext, msg: str):
self._warnings.append(
ParseIssue(ctx.line, ctx.column, ctx.text, msg, ParseIssue.Type.ERROR))

def _add_type(self, name: str, type_keynode: str):
try:
self._types[name].add(type_keynode)
except KeyError:
self._types[name] = {type_keynode}

def _link_remove_escape_symbols(self, input: str) -> str:
return input.replace("\\[", "[").replace("\\]", "]").replace("\\\\", "\\")

Expand Down
7 changes: 4 additions & 3 deletions db/tests/units/scs/test_scs_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@ def test_links(self):
)))
self.assertEqual(len(parser.triples), 4)

def test_type_error(self):
def test_type_no_error(self):
parser = SCsParser()
self.assertFalse(parser.parse((
self.assertTrue(parser.parse((
"a <- sc_node_abstract;;"
"a <- sc_node_role_relation;;"
)))
self.assertTrue(parser.has_errors())
self.assertFalse(parser.has_errors())
self.assertEqual(len(parser.triples), 2)