Skip to content

Some improvements #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deniskoronchik merged 10 commits into from
May 1, 2018
Merged

Some improvements #282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
557e546
[python] Improve python typings
deniskoronchik Feb 4, 2018
4a30afa
[python] Implement ScHelper
deniskoronchik Feb 4, 2018
3a5fd71
[python] Some improvements
deniskoronchik Feb 4, 2018
b617759
[docs] Doc packages update
deniskoronchik Feb 4, 2018
2666b96
[python] Add new functions to ScHelper
deniskoronchik Feb 4, 2018
506d1ec
[tools] Some small fixes in builder
deniskoronchik Mar 4, 2018
487c4db
[cpp][python] Some fixes in python wrapper
deniskoronchik Apr 8, 2018
9dec19f
[doc] Some documentation improvements
deniskoronchik Apr 8, 2018
1a1dd63
[docs] Update changelog
deniskoronchik Apr 8, 2018
8e968cf
Fix clang build
deniskoronchik Apr 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[cpp][python] Some fixes in python wrapper
  • Loading branch information
@deniskoronchik
deniskoronchik committed Apr 8, 2018
commit 487c4db94cc1f9001f6e20a718d75f617cf5cdf8
3 changes: 3 additions & 0 deletions sc-kpm/python/sc_tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,8 +415,11 @@ def test_helper_template(self):
params = ScTemplateGenParams()
params.Add("_target", addr2)

self.assertEqual(params.Get("_target_none"), None)

genResult = ctx.HelperGenTemplate(templ, params)
self.assertTrue(type(genResult) is ScTemplateGenResult)
self.assertEqual(genResult["not_exist"], None)

# search by this template and compare results
searchResult = ctx.HelperSearchTemplate(templ)
Expand Down
15 changes: 13 additions & 2 deletions sc-memory/cpp/python/sc_python_module.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,20 @@ class PyTemplateGenResult
return *m_result;
}

ScAddr Get(std::string const & name) const
bp::object Get(std::string const & name) const
{
return (*m_result)[name];
ScAddr value;

try
{
value = (*m_result)[name];
}
catch (utils::ExceptionItemNotFound const & ex)
{
return bp::object();
}

return bp::object(value);
}

size_t Size() const
Expand Down