Micro optimize URL

bench/snippets/url.mjs

@@ -0,0 +1,7 @@
+import { bench, run } from './runner.mjs'
+
+bench('url', () => {
+  const url = new URL('https://example.com/')
+})
+
+await run()

src/bun.js/bindings/DOMURL.cpp

@@ -49,7 +49,7 @@ namespace WebCore {
 
 static inline String redact(const String& input)
 {
-    if (input.contains("@"_s))
+    if (input.contains('@'))
         return "<redacted>"_s;
 
     return makeString('"', input, '"');
@@ -61,6 +61,14 @@ inline DOMURL::DOMURL(URL&& completeURL)
     ASSERT(m_url.isValid());
 }
 
+ExceptionOr<Ref<DOMURL>> DOMURL::create(const String& url)
+{
+    URL completeURL { url };
+    if (!completeURL.isValid())
+        return Exception { TypeError, makeString(redact(url), " cannot be parsed as a URL.") };
+    return adoptRef(*new DOMURL(WTFMove(completeURL)));
+}
+
 ExceptionOr<Ref<DOMURL>> DOMURL::create(const String& url, const URL& base)
 {
     ASSERT(base.isValid() || base.isNull());

src/bun.js/bindings/DOMURL.h

@@ -43,6 +43,7 @@ class URLSearchParams;
 class DOMURL final : public RefCounted<DOMURL>, public CanMakeWeakPtr<DOMURL>, public URLDecomposition {
 public:
     static ExceptionOr<Ref<DOMURL>> create(const String& url, const String& base);
+    static ExceptionOr<Ref<DOMURL>> create(const String& url);
     WEBCORE_EXPORT ~DOMURL();
 
     static RefPtr<DOMURL> parse(const String& url, const String& base);

src/bun.js/bindings/webcore/JSDOMURL.cpp

@@ -152,7 +152,7 @@ template<> EncodedJSValue JSC_HOST_CALL_ATTRIBUTES JSDOMURLDOMConstructor::const
     EnsureStillAliveScope argument1 = callFrame->argument(1);
     auto base = argument1.value().isUndefined() ? String() : convert<IDLUSVString>(*lexicalGlobalObject, argument1.value());
     RETURN_IF_EXCEPTION(throwScope, encodedJSValue());
-    auto object = DOMURL::create(WTFMove(url), WTFMove(base));
+    auto object = base.isEmpty() ? DOMURL::create(WTFMove(url)) : DOMURL::create(WTFMove(url), WTFMove(base));
     if constexpr (IsExceptionOr<decltype(object)>)
         RETURN_IF_EXCEPTION(throwScope, {});
     static_assert(TypeOrExceptionOrUnderlyingType<decltype(object)>::isRef);