This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Fix misleading SSL/TLS SMTP email configuration #2688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RealRancor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BernhardPosselt, @carlaschroder and @j-ed to be potential reviewers. |
This was referenced Oct 22, 2016
phil-davis
reviewed
Oct 22, 2016
| ^^^ | ||
| A secure connection will be initiated using the STARTTLS protocol which | ||
| uses the default port 25/tcp: | ||
| STARTLS |
Author
There was a problem hiding this comment.
Outsch, good eyes. Too many SSL/TLS/STARTTLS in here :-)
Thanks for the review!!
Author
|
owncloud/core#26447 was merged and is currently backported down to stable8.1 so i will also do the backports of the docs after this here was merged. |
ghost
deleted the
This was referenced Oct 24, 2016
ghost
mentioned this pull request
Author
|
Backports linked above. |
Contributor
|
Thanks, all merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #1778
This is also noted in swiftmailer/swiftmailer#545