documentation for UI tests #3049
Conversation
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
I have just checked how it reads.
Next I should try to follow the instructions...
| Set Up test | ||
| ~~~~~~~~~~~ | ||
| - place the selenium standalone server jar file and the webdriver(s) somewhere in the same folder | ||
| - start the selinium server ``java -jar selenium-server-standalone-3.0.1.jar -port 4445`` |
| ~~~~~~~~~~~ | ||
| - place the selenium standalone server jar file and the webdriver(s) somewhere in the same folder | ||
| - start the selinium server ``java -jar selenium-server-standalone-3.0.1.jar -port 4445`` | ||
| - set following environment variables: |
| Known issues | ||
| ~~~~~~~~~~~~ | ||
|
|
||
| - webdriver for current Firefox is not working correctly, so we need to test on 47.0.2 and to use selenium server 2.53.1 for it |
There was a problem hiding this comment.
"the webdriver for the current Firefox..."
I think the little words here make it read more nicely.
|
|
||
| Requirements: | ||
| ~~~~~~~~~~~~~ | ||
| - ownCloud >= 10.0 (make sure you have an running instance of ownCloud complete setup) |
| Requirements: | ||
| ~~~~~~~~~~~~~ | ||
| - ownCloud >= 10.0 (make sure you have an running instance of ownCloud complete setup) | ||
| - admin user called "admin" with the password "admin" |
| export BROWSER=chrome | ||
|
|
||
|
|
||
| - if you don't have a webserver already running start php development server with: |
There was a problem hiding this comment.
suggestion: "start the PHP development server", not "start php development server"
|
|
||
| - if you don't have a webserver already running start php development server with: | ||
| ``bash tests/travis/start_php_dev_server.sh`` (leave SRV_HOST_URL empty in that case. ``export SRV_HOST_URL=""``) | ||
| The server will bind to: $SRV_HOST_NAME:$SRV_HOST_PORT |
There was a problem hiding this comment.
I'd suggest that you surround $SRV_HOST_NAME:$SRV_HOST_PORT with double backticks, to render it as code.
| - if you don't have a webserver already running start php development server with: | ||
| ``bash tests/travis/start_php_dev_server.sh`` (leave SRV_HOST_URL empty in that case. ``export SRV_HOST_URL=""``) | ||
| The server will bind to: $SRV_HOST_NAME:$SRV_HOST_PORT | ||
| - run tests: ``bash tests/travis/start_behat_tests.sh`` |
There was a problem hiding this comment.
suggestion: "run the tests", not "run tests"
| Known issues | ||
| ~~~~~~~~~~~~ | ||
|
|
||
| - the webdriver for the current Firefox is not working correctly, so we need to test on 47.0.2 and to use selenium server 2.53.1 for it |
There was a problem hiding this comment.
suggestion: "for the current version of Firefox", not "the current Firefox"
| ~~~~~~~~~~~~ | ||
|
|
||
| - the webdriver for the current Firefox is not working correctly, so we need to test on 47.0.2 and to use selenium server 2.53.1 for it | ||
| - download and install version 47.0.2 of firefox from here: https://ftp.mozilla.org/pub/firefox/releases/47.0.2/ |
There was a problem hiding this comment.
Do you need a specific version of Firefox, or will the latest version work properly?
There was a problem hiding this comment.
we need version 47.0.2 of Firefox and version 2.53.1 of selenium server
| - place the selenium standalone server jar file and the webdriver(s) somewhere in the same folder | ||
| - start the selenium server ``java -jar selenium-server-standalone-3.0.1.jar -port 4445`` | ||
| - set the following environment variables: | ||
| - SRV_HOST_NAME (the hostname where ownCloud runs) |
There was a problem hiding this comment.
I'd suggest surrounding SRV_HOST_NAME, and the other three environment variables in double backticks
settermjd
left a comment
settermjd
left a comment
There was a problem hiding this comment.
On the whole it looks fine, comments aside. I can't comment on it working, as I've not tested it, however.
| ~~~~~~~~~~~~~ | ||
| - ownCloud >= 10.0 (make sure you have an running instance of ownCloud completely setup) | ||
| - default language set to "en" (in ``config/config.php`` set ``'default_language' => 'en',``) | ||
| - skeletondirectory set to ``<owncloud-base-folder>/tests/ui/skeleton`` |
There was a problem hiding this comment.
s/skeletondirectory/skeleton directory/g
settermjd
left a comment
settermjd
left a comment
There was a problem hiding this comment.
One last change, then it's fine by me.
documenting how to run UI tests locally
the full scope of this process will work after owncloud/core#27838 is merged
for implementation see also owncloud/core#27316