Restructure tests for avoiding duplicated code.

[SergioBertolinSG]

While integration tests are starting to spread across apps we'll need to have a way to avoid duplicated code, so we only need to modify code in one place instead of several.

Reference owncloud/customgroups#17

But also related with https://github.com/owncloud/windows_network_drive/pull/70 and others incoming.

@DeepDiver1975 @PVince81

[PVince81]

As discussed:

• in the app's integration tests folder, make the autoloader also point at core's build/integration to be able to reuse the Webdav/Sharing/... classes
• in the app's integration test bootstrap, make it use whichever classes/traits from core are needed (ex: Webdav, etc)

This would make it possible to write tests using the same syntax and utilities from core.

[PVince81]

I also suggest we first move "build/integration" to "tests/integration" as suggested by @DeepDiver1975 here owncloud/core#27057 (comment). This is important because we'll likely need to hard-code the path to the tests inside the app for the autoloader.

[DeepDiver1975]

This is important because we'll likely need to hard-code the path to the tests inside the app for the autoloader.

yes - and we shall also add the dependencies to the regular composer.json as dev dependencies

[PVince81]

the regular composer.json

which one ? core's composer.json or build/integration/composer.json ?

It would be good to only have a single composer.json per repository.

[DeepDiver1975]

build/integration/composer.json to go into core/composer.json

[SergioBertolinSG]

As this will affect all apps lets discuss this comment here (owncloud/customgroups#17 (comment)):

Problem with changing autoloading (behat.yml):

Adding two elements with hyphens it fails:

• '': %paths.base%/../../../../../build/integration/features/bootstrap
• '': %paths.base%/../features/bootstrap

Result:

[Symfony\Component\Config\Definition\Exception\InvalidTypeException]          
  Invalid type for path "testwork.autoload.0". Expected scalar, but got array.

Without hyphens it loads only the content from the first path, not the second.

We need to figure out how to autoload contexts from both.

Perhaps using profiles?
Perhaps using composer's PSR-4 autoload mechanism?

[SergioBertolinSG]

This has been done in customgroups.