User trapped in app management screen

[nickvergessen]

Steps to reproduce

1. Open app management index.php/settings/apps
2. Try to click the cloud, or any app menu, or browser bookmark to switch the page

Expected behaviour

The page should load

Actual behaviour

App management reloads

Server configuration

Operating system: Linux Mint 17.3

PHP version: php 5.5.32

ownCloud version: master

Updated from an older ownCloud or fresh install: fresh

Where did you install ownCloud from: git

List of activated apps:

Enabled:
  - activity: 2.3.0
  - announcementcenter: 1.2.0
  - comments: 0.3.0
  - dav: 0.2.2
  - federatedfilesharing: 0.2.0
  - files: 1.5.1
  - files_sharing: 0.10.0
  - files_texteditor: 2.1
  - files_trashbin: 0.9.0
  - files_versions: 1.3.0
  - notifications: 0.3.0
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - updatenotification: 0.2.0
  - workflow: 0.2.0

The content of config/config.php:

{
    "system": {
        "debug": true,
        "trusted_domains": [
            "localhost",
            "owncloudmaster.local"
        ],
        "apps_paths": {
            "0": {
                "path": "\/home\/nickv\/ownCloud\/master\/core\/apps",
                "url": "\/apps",
                "writable": false
            },
            "1": {
                "path": "\/home\/nickv\/ownCloud\/master\/noapps",
                "url": "\/..\/noapps",
                "writable": true
            }
        },
        "loglevel": 1,
        "logtimezone": "UTC",
        "log_rotate_size": 52428,
        "appstore.experimental.enabled": true,
        "appstoreenabled": true,
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "9.1.0.0",
        "dbname": "oc_temp",
        "dbhost": "localhost",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "ocz6xyesfky4",
        "maintenance": false
    }
}

Are you using external storage, if yes which one: local

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 45

Operating system: Linux Mint 17.3

Logs

Web server error log

--- empty ---

ownCloud log (data/owncloud.log)

--- empty ---

Browser log

Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead jquery.min.js:1:0
Content Security Policy: Die Einstellungen der Seite haben das Laden einer Ressource auf self blockiert ("script-src http://localhost 'unsafe-eval'"). apps
Deprecation warning: tipsy is deprecated. Use tooltip instead. js.js:2183:2

@schiesbn can reproduce this as well on Iceweasle/Firefox 44

[oparoz]

Probably related to #23178

[nickvergessen]

Works after reverting #16783

[PVince81]

Commenting out the global ajax error handler makes the problem disappear: https://github.com/owncloud/core/blob/v9.0.0/core/js/js.js#L1441

I suspect that when leaving the page, the ajax call might be receiving an error.

[PVince81]

Looks like we get statusCode 0 and statusText "error" in the global handler when the user navigates away while ajax calls are running.

That code is responsible for detecting either a 401 error or a cross-domain redirect caused by SSO token timeout. Problem is, that one also returns a status code of 0.

[PVince81]

Just tested with a cross-domain redirect, and it also returns "0" and "error" 😦
This will be tricky to detect.

[PVince81]

Okay, let's have a try with http://stackoverflow.com/questions/1370322/jquery-ajax-fires-error-callback-on-window-unload-how-do-i-filter-out-unload-a

[PVince81]

That's a real nightmare... also need to detect whether an app is using "beforeunload" and the dialog pops up, and detect whether the user cancelled navigating away, and then reset the flag.
The horror: http://stackoverflow.com/a/25765797

Doesn't work very well... I'll just put a higher timeout value.