Skip to content

Scale up the font on larger previews #15635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 1 commit into from
Apr 20, 2015
Merged

Scale up the font on larger previews #15635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/preview/txt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function getThumbnail($path, $maxX, $maxY, $scalingup, $fileview) {

$lines = preg_split("/\r\n|\n|\r/", $content);

$fontSize = 5; //5px
$fontSize = ($maxX) ? (int) ((5 / 36) * $maxX) : 5; //5px
Copy link
Contributor Author

@nickvergessen nickvergessen Apr 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oparoz

Txt seems to be the only exception, so maybe it best to fix the public page than mess with the preview system?
Maybe use 3 instead of 5 for now so that small previews work and large previews are a bit less bad?
$fontSize = ($maxX) ? (int) ((3 / 36) * $maxX) : 5; //5px

Copy link
Contributor Author

@nickvergessen nickvergessen Apr 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oparoz I used 5 / 36 because this is the original font size that was used.

Copy link
Contributor

@oparoz oparoz Apr 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

$lineSize = ceil($fontSize * 1.25);

$image = imagecreate($maxX, $maxY);
Expand Down