Redirect properly while browsing the filelist

[MorrisJobke]

Needs to be verified, that it solves issues, when the server responds with a redirect due to i.e. authorization token expiry.

cc @butonic

[MorrisJobke]

Untested yet.

This PR is used for collaboration.

cc @CaptionF @PVince81

[DeepDiver1975]

@butonic the js unit test are failing to some extend - can you take care? THX

[DeepDiver1975]

Furhtermore this only helps in the files app - the issue is not fixed in case somebody has opened any other app.

[MorrisJobke]

Furhtermore this only helps in the files app - the issue is not fixed in case somebody has opened any other app.

But this has to be fixed in these apps. I will fix the unit tests tomorrow and test this.

[MorrisJobke]

@cmonteroluque This is currently in a testing/collaboration state (to get this sorted out between @butonic and me) ;)

[DeepDiver1975]

Potential global solution:http://api.jquery.com/ajaxerror/

[butonic]

Ok, I tested this with my local testshib setup and can reproduce the issue. it seems using statusCode to specify handlers does not work as documented (the functions for 302 and 307 are not triggered), so I used the redirect function as the error callback. jquery treats a 30x as an error and will call the error handler. with this the app is refreshed when the shibboleth session has expired (either by timeout or lifetime).

cc @CaptionF after the redirect the user will land at the idp. depending on how long the session is valid there the user will either have to relogin at the idp or will land in the files app.

this might even be improved by redirecting directly to the current folder.

[butonic]

@danimo thx for pointing out the test installation, I had a local shibboleth setup that I just needed to dust off (as in boot linux).

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/12697/

Build result: FAILURE

[...truncated 13 lines...] > git config --local --remove-section credential # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git1980496719437583187.credentials # timeout=10 > git -c core.askpass=true fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse refs/remotes/origin/pr/16726/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/16726/merge^{commit} # timeout=10Checking out Revision 59a438785efaaf392ea4a0c9fcf11f209403167c (refs/remotes/origin/pr/16726/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 59a438785efaaf392ea4a0c9fcf11f209403167cFirst time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILURESetting status of a78c9fe to FAILURE with url https://ci.owncloud.org/job/pull-request-analyser-ng-simple/12697/ and message: Build finished.
💣 Test FAILed. 💣

[DeepDiver1975]

jquery treats a 30x as an error and will call the error handler.

which is great as we can come up with a global solution - #16726 (comment)

@butonic let me know if you need further assistance on this - THX

[butonic]

closing in favor of #16783