Skip unnecessary cache updates #19494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way unnecessary updates can be skipped
the folder size will not change when changing the file mtime
change was in wrong routing tidy up
DeepDiver1975
force-pushed
the
individual-it_skip_unnecessary_cache_updates
branch
from
c9f28fd to
ec59be2
Compare
Display checkboxes properly after file restore
this way unnecessary updates can be skipped
the folder size will not change when changing the file mtime
change was in wrong routing tidy up
https://github.com/owncloud/core into individual-it_skip_unnecessary_cache_updates Conflicts: lib/private/files/cache/updater.php
MorrisJobke
changed the title
Contributor
|
cc @PVince81 @icewind1991 @schiesbn |
Contributor
|
Unfortunately the code now has move to the "apps/dav" app so this would need another rebase. But I'd like to know what @icewind1991 thinks of this approach and whether there is a better way that doesn't involve passing around a flag. Does the new improved propagation cover this ? |
Contributor
|
Closing due to lack of activity. Not sure how critical the fix is. If it is, feel free to reopen/resubmit. |
Contributor
|
Side note: cache update and etag propagation performance has been improved on other part of the code in 9.0/9.1 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rebased copy of the PR #18753
OC\Files\Cache\Updater::updatedoes a couple of updates. Not all are needed in every case the method is called.In this example if
touch()only is changing the mtime we should skip the update of the folder size as that would not change.