Skip to content

Conversation

@RobinMcCorkell
Copy link
Member

Errors should not be printed to the log if there's nothing to do (that's a good thing!)

Fixes #23747, fixes #23637

cc @enoch85 @DeepDiver1975 @LukasReschke

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @LukasReschke and @schiesbn to be potential reviewers

@enoch85
Copy link
Member

enoch85 commented Apr 4, 2016

Tested and working! 👍

@enoch85
Copy link
Member

enoch85 commented Apr 4, 2016

This is now in the VM: techandme/owncloud-vm@300cb2a

@enoch85
Copy link
Member

enoch85 commented Apr 4, 2016

Backport to stable 9 please?

@RobinMcCorkell
Copy link
Member Author

@enoch85 I'd advise you don't patch files in the VM, since they will fail the integrity check and cause confusion for users... Since these messages are only seen when creating the VM, I'd suggest we don't rush a backport for 9.0.1 and rather wait for 9.0.2 (but I'd be inclined to backport too, @karlitschek )

@enoch85
Copy link
Member

enoch85 commented Apr 5, 2016

Didn't think if that. You are right.

@DeepDiver1975
Copy link
Member

Looking at this as of now - it might be better to simply return a boolean from the setup method and don't run the migration based on it's result.

There is no need for an exception here

@RobinMcCorkell
Copy link
Member Author

@DeepDiver1975 Feel free to push here to fix it, you'll know how to organise the code better 😄

@DeepDiver1975
Copy link
Member

@DeepDiver1975 Feel free to push here to fix it, you'll know how to organise the code better 😄

will do

@enoch85
Copy link
Member

enoch85 commented Jun 27, 2016

This should be merged as @DeepDiver1975 yet haven't written an improvement of this PR.

@enoch85 enoch85 restored the dav-suppress-warnings branch June 27, 2016 17:47
@enoch85 enoch85 reopened this Jun 27, 2016
@enoch85 enoch85 added this to the 9.1-current milestone Jun 27, 2016
@DeepDiver1975
Copy link
Member

This should be merged as @DeepDiver1975 yet haven't written an improvement of this PR.

No needs - the migration code has been dropped already for 9.1

@DeepDiver1975 DeepDiver1975 deleted the dav-suppress-warnings branch June 27, 2016 18:29
@enoch85
Copy link
Member

enoch85 commented Jun 27, 2016

@DeepDiver1975 What about backport then?

@DeepDiver1975
Copy link
Member

@DeepDiver1975 What about backport then?

valid point - I'll prepare a pr - THX

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

6 participants