-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Suppress warnings from DAV migration if there's nothing to do #23790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975, @LukasReschke and @schiesbn to be potential reviewers |
|
Tested and working! 👍 |
|
This is now in the VM: techandme/owncloud-vm@300cb2a |
|
Backport to stable 9 please? |
|
@enoch85 I'd advise you don't patch files in the VM, since they will fail the integrity check and cause confusion for users... Since these messages are only seen when creating the VM, I'd suggest we don't rush a backport for 9.0.1 and rather wait for 9.0.2 (but I'd be inclined to backport too, @karlitschek ) |
|
Didn't think if that. You are right. |
|
Looking at this as of now - it might be better to simply return a boolean from the setup method and don't run the migration based on it's result. There is no need for an exception here |
|
@DeepDiver1975 Feel free to push here to fix it, you'll know how to organise the code better 😄 |
will do |
|
This should be merged as @DeepDiver1975 yet haven't written an improvement of this PR. |
No needs - the migration code has been dropped already for 9.1 |
|
@DeepDiver1975 What about backport then? |
valid point - I'll prepare a pr - THX |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Errors should not be printed to the log if there's nothing to do (that's a good thing!)
Fixes #23747, fixes #23637
cc @enoch85 @DeepDiver1975 @LukasReschke