On mount make sure multiple shares with same target map to unique ones #23937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @icewind1991, @MorrisJobke and @schiesbn to be potential reviewers |
Contributor
Author
|
@LukasReschke fixed :) |
Member
|
👍 |
Contributor
|
Tested and works 👍 |
Contributor
|
Code looks good 👍 |
Member
|
has conflicts @rullzer |
Contributor
Author
Was in the intergration test file => resolved... |
Contributor
Author
|
@DeepDiver1975 please merge :) |
Scenario: user0 shares a folder 'foo' with user2 user1 shares a folder 'foo' with user2 user2 logs in Before: show only the 'foo' from user1 After: show both. * Added intergration tests
Contributor
|
We need to backport this to OC 9.0 to fix the regression there too: #25244 I'll prepare the PR |
PVince81
pushed a commit
that referenced
this pull request
Jun 23, 2016
#23937) Scenario: user0 shares a folder 'foo' with user2 user1 shares a folder 'foo' with user2 user2 logs in Before: show only the 'foo' from user1 After: show both. * Added intergration tests
Contributor
|
stable9: #25248 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while migrating the sharedStorage.
I think this is the result of recent moving around of stuff. But we did not notice because there was no testing for it. (not with 2 incomming shares). Works fine in 9.0 as far as I can tell.
Scenario:
Before: show only the 'foo' from user1
After: show both.
CC: @schiesbn @icewind1991 @nickvergessen @MorrisJobke