Fix Decrypt message via occ #24992
Merged
Fix Decrypt message via occ #24992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $result = $this->decryptAll->decryptAll($input, $output, $user); | ||
| if ($result === false) { | ||
| $output->writeln(' aborted.'); | ||
| $output->write('Enable server side encryption... '); |
Contributor
Author
|
core/core/Command/Encryption/DecryptAll.php Line 133 in eaeb5d6 |
Contributor
|
@davitol did you try changing this check instead core/lib/private/Encryption/DecryptAll.php Line 144 in eaeb5d6 Or is a zero user causing issues in more pieces of the code ? |
|
|
||
| $uid = $input->getArgument('user'); | ||
| //FIXME WHEN https://github.com/owncloud/core/issues/24994 is fixed | ||
| if (empty($uid)) { |
Contributor
There was a problem hiding this comment.
if ($uid === null) {to allow user name '0' to act correctly.
Or
if ($uid === '') {after my patch for #24994
Contributor
|
Needs rebase after #24998 is merged |
Contributor
|
I'll take this over. |
Contributor
|
👍 |
Contributor
|
👍 |
Member
Member
|
I'll take care about the backport |
Contributor
|
stable9: #25188 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23695